From 3fd68c3a31049e8bc9489c680dd6e65ab0631720 Mon Sep 17 00:00:00 2001 From: ocornut Date: Wed, 10 Sep 2014 12:21:33 +0100 Subject: [PATCH] Fixed file-descriptor leak if ImBitmapFont::LoadFromFile() calls to seek/tell fails. --- imgui.cpp | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/imgui.cpp b/imgui.cpp index 27cc46a6..5addb6a8 100644 --- a/imgui.cpp +++ b/imgui.cpp @@ -5190,13 +5190,22 @@ bool ImBitmapFont::LoadFromFile(const char* filename) if ((f = fopen(filename, "rb")) == NULL) return false; if (fseek(f, 0, SEEK_END)) + { + fclose(f); return false; + } const long f_size = ftell(f); if (f_size == -1) + { + fclose(f); return false; + } DataSize = (size_t)f_size; if (fseek(f, 0, SEEK_SET)) + { + fclose(f); return false; + } if ((Data = (unsigned char*)IM_MALLOC(DataSize)) == NULL) { fclose(f);