Commit Graph

5124 Commits (30d81f53cbdb73f88ab049d21fc7a00cf548c8c8)
 

Author SHA1 Message Date
omar bfaa426f7f Nav: Minor tidying up (adding local variables to be a little more sane).
omar 8a5a29f0be Nav: Renamed internal field.
omar 9712a81f85 Nav: Rectangle rectangle stored per window and per layer as well. Makes things simpler, allows enable us to visualize more data.
omar 54eb4c485e Nav: Marked misleading/broken code that will never execute.
omar e3c89aeb10 Nav: Fixed menuitems/selectable on menu layer (layer 1) from storing themselves in wrong layer of LastNavIds when hovered.causing inconsistencies and bugs when hovering menu with mouse then pressing ALT to return to layer 0).
NB: this is not a new bug introduced by the previous commit (which is related to nav layers), bug has been there for a while. ()
omar 9737efb2f1 Nav: Store per-window last nav id also per-layer so we can easily query them for menu navigation code. ()
omar 8a814487fe Merge branch 'master' into navigation
# Conflicts:
#	imgui.cpp
#	imgui_internal.h
omar fba9353c60 BeginMenu: Shuffling braces around to clarify flow
omar cf308f4039 Nav: Fixed SetItemDefaultFocus from stealing default focus when we are initializing default focus for a menu bar layer ()
omar f4398226cc Nav: Support for fallback horizontal scrolling with PadLeft/PadRight (nb: fallback scrolling is only used to navigate windows that have no interactive items). ()
omar 30b1d85962 Nav: Commiting some better organized Debug helper because this going to stay for a bit.
omar 3b85a8b6a0 Demo: Added an extra test related to baseline and fixed an id collision.
omar 164f22d5b7 Comments
omar 1f7f54e196 Removed extraneous test.
omar c0cf123e0b Update README.md
omar df366b230e ColorPicker4: Use nav flag to provide a slighly better experience when using navigation (, )
omar 7c2926de17 Demo: Added an extra test related to baseline and fixed an id collision.
omar 2d859dee4e Nav: Added ImGuiItemFlags_NoNav item flag
omar 878fa96896 Nav: Re-arranged ItemAdd() to maximize early out ()
omar dd0855de5c ButtonBehavior: Tidying up.
omar 4b4e455c40 Nav: Internal nenaming
omar 50ba543743 Comments
omar e0a2a832cd Nav: Changed internal flag to NoNavDefaultFocus to be false by allow, and more consistent ()
omar af38749ea1 Nav: Fixed ButtonBehavior mistakenly setting active id when the Activate button is held and we have a new NavId, which affected browsing some popups ()
omar ca4db8c905 Merge branch 'master' into navigation
# Conflicts:
#	imgui.cpp
#	imgui_internal.h
omar e8f7c83138 Begin: Shallow tweak to minimize diff with nav branch
omar 926c1cf9a4 Merged from Navigation branch: ImGuiItemFlags_SelectableDontClosePopup flag
omar f99348711b Added VerticalSeparator() entry point in imgui_internal. Seperator() in an horizontal layout context still does that.
omar 9142002121 Separator(): Tweak Logging so that the separator text is aligned according to tree padding.
omar d394c7ad0b Merge branch 'master' into navigation
# Conflicts:
#	imgui.cpp
#	imgui_internal.h
omar 0106dcbd02 Fixed IsItemHovered() - part of the processing has to be done in ItemAdd() because the widget may alter clipping rectangle temporarily.
omar 2a8eb618dc Nav: Fixed NavDown to open menu from a menu bar ()
omar 35f65e05ed Merge branch 'master' into navigation
omar fafe65a8fc Refactor to move the responsability of SetHovered() to ItemHoverable() - previously IsHovered(). Simpler and the parallel to ItemAdd is clearer with the new name.
omar 2159629e9e Removed another msileading difference between the hovered functions (IsWindowContentHoverable() uses the root window already). Sorry for the commit spam! (making small commit to easily be able to Bisect those in case I make a mistake)
omar eca74d55c7 IsItemHovered(), IsHovered(): Shallow tweaks, eventually removed all the braces.
omar 2b7d4c713e Internals: Moved IsWindowContentHoverable() in the file
omar c5a79deb38 IsItemHovered(), IsHovered(): Shallow tweaks to make them more symetrical. Removed one set of braces.
omar 7bcb1d3816 Internals: ButtonBehavior(), IsHovered() moved the responsability of flatten_child higher level to ButtonBehavior() - not super sure about the elegance of this
omar 79ef64430c Nav: Fixed merge cc26db8ec7
omar cc26db8ec7 Merge branch 'master' into navigation
omar 0adcddac39 IsItemHovered(), ItemAdd(): finishing cleaning up, moved the code to IsItemHovered() so ItemAdd() is more lightweight and the two IsXXXHovered functions are now very similar, making their differences less confusing.
omar 19e22baa06 ItemAdd(): more re-ordering of tests to match IsHovered() + comments
omar 344d48be31 IsItemHovered(), ItemAdd(): Fixed seemingly unnecessary comparaison of root windows, makes IsItemHovered() more consistent with internal IsHovered().
Original test was added in 6e99688fa7 should not have been using RootWindow in the first place.
The difference between public-facing and internal versions would only be noticeable with overlapped child windows, which doesn't really happen anyway
omar c075786d8b ItemAdd(): re-ordering the tests, submission should now be faster.
omar 99c7622a1b ItemAdd(), not performing computation for IsItemRectHovered() which does them itself, allowing us in the next commit to optimize ItemAdd() and make its logic more consistent with IsHovered().
omar e87ad328e4 Moved implementation of Hovered-related functions next to each others + comments, before I attempt to work on them. No functional change here.
omar 842e88a8e3 Examples: Avoid using ImColor() to not tempt newcomers into looking at it
omar 869732c456 Nav: Removed unnecessary combo code (that kept the combo arrow highlighted after reverting to mouse controls). ()
omar a2b2e56e8e Merge branch 'master' into navigation